Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to `yarn` for dependency management #9132

Merged
merged 3 commits into from Mar 13, 2019

Conversation

@jryans
Copy link
Member

jryans commented Mar 12, 2019

Most npm operations are replaced with yarn, which generally has better
behavior. However, steps like publish that write to the NPM registry are left to
npm, which currently handles these tasks best.

Part of #7756

Previously reviewed portion for JS SDK: matrix-org/matrix-js-sdk#856
Under review portion for React SDK: matrix-org/matrix-react-sdk#2773

jryans added 3 commits Mar 11, 2019
The npm lock file was imported into yarn. A yarn install pass was then run to
double-check the lock file for sanity.
We did not previously commit lock files for the Electron app, so there is no
correct copy to import from. For this directory, I created a fresh yarn lock
file using yarn install.
Most `npm` operations are replaced with `yarn`, which generally has better
behavior. However, steps like publish that write to the NPM registry are left to
`npm`, which currently handles these tasks best.
@jryans jryans requested a review from vector-im/riot-web Mar 12, 2019
@turt2live turt2live self-requested a review Mar 12, 2019
@jryans jryans merged commit 1abaf50 into vector-im:develop Mar 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jryans jryans referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.