Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When restoring tabs in firefox, vector gets stuck replaying old history #1354

Closed
ara4n opened this issue Apr 9, 2016 · 5 comments
Closed

When restoring tabs in firefox, vector gets stuck replaying old history #1354

ara4n opened this issue Apr 9, 2016 · 5 comments
Assignees
@richvdh
Labels
P1 T-Defect
Milestone
v1 - Private Preview

Comments

@ara4n
Copy link
Member

ara4n commented Apr 9, 2016

Apparently vector's state is restored from the point of suspension and then replays forwards rather than jumping forwards via a gappy sync. Notifications fire too. Reported by @eternaleye and @aviraldg
@ara4n ara4n added this to the v2 - Public Preview milestone Apr 10, 2016
@ara4n
Copy link
Member Author

ara4n commented Apr 11, 2016

(meanwhile I just saw Thea's Chrome spawn a fleet of desktop notifications during catchup after unsleeping on /beta, which may or may not be related...)

@ara4n ara4n added P1 and removed P2 labels Apr 13, 2016
@ara4n
Copy link
Member Author

ara4n commented Apr 13, 2016

Yet more evidence of broken catchup: https://vector.im/develop/#/room/#freenode_#matrix:matrix.org/$14605455921524zIpus:half-shot.uk

@ara4n
Copy link
Member Author

ara4n commented Apr 13, 2016

assigning to rich as it really sounds like something is going wrong with the timeline if we're replaying forwards rather than gappy-syncing

richvdh added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 13, 2016
@richvdh
Log sync token when starting sync loop
526e1d5 
A little bit of debug that might help with
element-hq/element-web#1354
@richvdh
Copy link
Member

richvdh commented Apr 13, 2016

I'm baffled by this. As far as I understand it, firefox session restore doesn't preserve anything that is in regular memory in javascript, and we don't (currently) use localstorage to save events or a sync token - so I don't know where the old events are coming from.

richvdh added a commit that referenced this issue Apr 13, 2016
@richvdh
Add some debug to help with FF restore bug
77355cb 
(#1354)
@richvdh
Copy link
Member

richvdh commented Apr 13, 2016

With a bit of luck this might have been fixed by matrix-org/matrix-js-sdk@0282021

@richvdh richvdh closed this as completed Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
P1 T-Defect
Projects
None yet
Milestone
v1 - Private Preview
Development

No branches or pull requests
2 participants
@ara4n @richvdh