Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 "Your Riot Validation Token" emails received for new account #2447

Closed
niedzielski opened this issue Oct 10, 2016 · 4 comments
Closed

70 "Your Riot Validation Token" emails received for new account #2447

niedzielski opened this issue Oct 10, 2016 · 4 comments

Comments

@niedzielski
Copy link

I created a new riot.im account and quickly received 70 emails with "Your Riot Validation Token" in the subject. They all seem to contain the same message:

Hello,

We have received a request from <my IP address> to register this email address on riot.im. If this was you who made this request, you may use the following link to complete the verification of your email address:

Complete email verification

Please note that Riot requires Chrome, Firefox or Safari on the web, or iOS or Android on mobile.

If you aren't aware of making such a request, please disregard this email.

thanks,

Riot

I confirmed the address within the first 10-20 messages but they kept coming for a bit. They might still be coming and my email provider has just banned the sender.

@niedzielski
Copy link
Author

Reported fixed by Matthew at about 0000 GMT:

an API changed in synapse's registration process which interacted very badly with the current live Riot-web app :(
and it looks as if the API may have been accidentally deployed in production before being tested
not sure this was a branching screwup; more someone accidentally updating production code when they actually meant to just update production config
and so doing an accidental deploy :(

Matthew is emailing those affected. I've not received an email but perhaps my provider (1and1 via Gmail) is blocking the domain.

@ara4n
Copy link
Member

ara4n commented Oct 11, 2016

Everyone affected should have received an apologetic email at 00:20 GMT.

This looks to be due to matrix-org/synapse#1160 having accidentally made its way onto the production matrix.org homeserver and interacting badly with riot.im/app, which tight-looped on registration.

@ara4n
Copy link
Member

ara4n commented Oct 11, 2016

ftr the root cause of this was matrix-org/matrix-react-sdk#510 (exposed by the server API refinement)

richvdh added a commit to matrix-org/synapse that referenced this issue Oct 11, 2016
5d9546f introduced a change to synapse behaviour, in that failures in the
interactive-auth process would return the flows and params data as well as an
error code (as specced in matrix-org/matrix-spec-proposals#397).

That change exposed a bug in Riot which would make it request a new validation
token (and send a new email) each time it got a 401 with a `flows` parameter
(see element-hq/element-web#2447 and the fix at
matrix-org/matrix-react-sdk#510).

To preserve compatibility with broken versions of Riot, grandfather in the old
behaviour for the email validation stage.
@niedzielski
Copy link
Author

I later received the follow-up email and notification mails seem to be working too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants