Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching rooms whilst you're on a call mutes the call #31

Closed
ara4n opened this issue Aug 29, 2015 · 1 comment
Closed

Switching rooms whilst you're on a call mutes the call #31

ara4n opened this issue Aug 29, 2015 · 1 comment
Labels
P2 T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Aug 29, 2015

We should let calls run in the background, to aid multitasking, and probably assert that only one can run at a time. (Use multiple tabs if you really want to two-time!)
@ara4n ara4n added the T-Defect label Aug 29, 2015
kegsay added a commit that referenced this issue Sep 15, 2015
@kegsay
Pass the call around different CallViews to keep media flowing
59986d8 
Previously, the CallView was attached to the RoomView, so you would get
a new CallView each time you changed the room and the one you changed
from would be destroyed. This would destroy media capture/playback as
the element was no longer in the DOM.

This is now fixed by having a "global" CallView which is attached at
the MatrixChat "page" level in the DOM hierarchy. This CallView isn't
scoped to a particular room; it will render any "active" call it can
find that *isn't the current room being displayed*. This has the side
effect of enforcing 1 call per app semantics as only the first active
call found is returned.

This fixes #31
This is unfinished (CSS for the global call view isn't done)
@kegsay
Copy link
Contributor

kegsay commented Sep 15, 2015

59986d8b

@kegsay kegsay mentioned this issue Sep 15, 2015
Merged
@dbkr dbkr closed this as completed in #160 Sep 18, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @kegsay