Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll-to-token is causing my browser to jump around erratically when the window is relatively small #946

Closed
ara4n opened this issue Feb 16, 2016 · 4 comments
Assignees
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Platform-Specific

Comments

@ara4n
Copy link
Member

ara4n commented Feb 16, 2016

I assume something in the layout or wrapping logic is causing the scroll-to-token stuff to break badly - at seemingly random points the window scroll offset jumps up half a page - e.g. when alt-tabbing away and back again, or when someone speaks in the room, or when you speak, etc. It's screwing up a demo i'm trying to record, so going to temporarily kill it on develop just so I can demo it properly.

https://matrix.org/_matrix/media/v1/download/matrix.org/jrQJJXgvXmnnmYxWRHvosjxZ

@ara4n ara4n added T-Defect P1 S-Critical Prevents work, causes data loss and/or has no workaround X-Release-Blocker labels Feb 16, 2016
@ara4n ara4n added this to the v0 - Friendly Beta milestone Feb 16, 2016
ara4n added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 16, 2016
@richvdh
Copy link
Member

richvdh commented Feb 16, 2016

oh, arse. sorry, I'll take a look.

@ara4n
Copy link
Member Author

ara4n commented Feb 16, 2016

This superficially looks like it might be linked to me disabling permenant scrollbars in OSX this morning, which in turn disables gemini, and could be introducing new DOM layout changes which get confused for scroll events by ScrollPanel...

@ara4n ara4n added Z-Platform-Specific T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist and removed T-Defect S-Critical Prevents work, causes data loss and/or has no workaround X-Release-Blocker labels Feb 16, 2016
@richvdh richvdh assigned ara4n and unassigned richvdh Feb 16, 2016
@richvdh
Copy link
Member

richvdh commented Feb 17, 2016

For the record: I was able to reproduce this on Linux by editing gemini-scrollbar/index.js to return 0 early in getScrollBarWidth(). It seems you also need to have messages of a certain minimum length in the room (enough to wrap?) to repro it.

@ara4n
Copy link
Member Author

ara4n commented Feb 17, 2016

looks like 3c659dc fixed it, thankfully. #947 seems to be intimately connected - something to do with the fact that the text would layout without wrapping with infinite width, and then flexbox would later layout and cause it to wrap down, changing the vertical height and causing a pseudo-scroll event. Not entirely sure how the overflow-x: auto on middle panel fixes it, but it allows the horizontal flexboxing of left/middle/right to not be pushed out enormously by middle.

@ara4n ara4n closed this as completed Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Platform-Specific
Projects
None yet
Development

No branches or pull requests

2 participants