Wmwragg/mention state menu #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and below the name
…e room name if too long
…ow. OnClick closes menu
…ention-state-menu # resolved Conflicts: # src/skins/vector/css/vector-web/views/rooms/RoomTooltip.css
…as they were causeing untraceable react errros for some reason
…s faded and disabled options
… it pasues breifly before closing, so that the user can see their state change has taken place.
…vatar, but don't show the mute icon
|
Can one of the admins verify this patch? |
…ch design in both normal and collapsed states
…d. Also search box gutters fixed
| @@ -94,7 +94,7 @@ limitations under the License. | |||
| background-color: #eaf5f0; | |||
|
|
|||
| -webkit-flex: 0 0 210px; | |||
| flex: 0 0 210px; | |||
| flex: 0 0 235px; | |||
There was a problem hiding this comment.
hm, the -webkit-flex is now out of sync with the flex
There was a problem hiding this comment.
I don't think that the -webkit-flex is used anymore, but I've corrected anyway
|
LGTM modulo comment - thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1841 and closes #1746. A companion branch matrix-org/matrix-react-sdk:wmwragg/mention-state-menu also needs to be merged.
Signed-off-by: William Wragg wm.wragg@gmail.com