Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow project relative path for cmake.cmakePath #569

Closed
Farigh opened this issue Oct 25, 2018 · 1 comment
Closed

Allow project relative path for cmake.cmakePath #569

Farigh opened this issue Oct 25, 2018 · 1 comment
Assignees
@vector-of-bool
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature
Milestone
1.1.3

Comments

@Farigh
Copy link

Farigh commented Oct 25, 2018 •
edited

Brief Issue Summary

The cmake-kits.json file property cmake.cmakePath expects the binary fullpath. Passing a relative path results in an error message

Bad CMake executable "<path>". Is it installed or settings contain the correct Path (cmake.cmakePath)?

Expected:

I'd like to be able to specify a relative path (to the cmake-kits.json file or the ${workspaceRoot})

Some context

Our project deploys the CMake and Make binaries via packages within our project directory
@vector-of-bool vector-of-bool added the enhancement an enhancement to the product that is either not present or an improvement to an existing feature label Nov 27, 2018
@vector-of-bool vector-of-bool added this to the On Deck milestone Nov 27, 2018
@vector-of-bool vector-of-bool self-assigned this Nov 27, 2018
@vector-of-bool
Copy link
Contributor

cmake-kits.json doesn't have a cmakePath property. Are you referring to cmake.cmakePath in settings.json?

It's a simple modification to get a relative path to resolve relative to the workspace folder directory.

@vector-of-bool vector-of-bool modified the milestones: On Deck, 1.1.3 Nov 27, 2018
@tcanens tcanens mentioned this issue Sep 24, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vector-of-bool vector-of-bool

Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature
Projects
None yet
Milestone
1.1.3
Development

No branches or pull requests
2 participants
@Farigh @vector-of-bool