Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/reset progress when finished #394

Merged
merged 3 commits into from Apr 23, 2018
Merged

Bugfix/reset progress when finished #394

merged 3 commits into from Apr 23, 2018

Conversation

bbosnjak
Copy link
Contributor

This changes visible behavior

When building second time progress bar is shortly shown as 100%.
Resetting progress variable when build is finished assures that initial progress bar is set to 0%

@KoeMai KoeMai mentioned this pull request Apr 22, 2018
Merged
@vector-of-bool vector-of-bool self-requested a review April 23, 2018 03:30
vector-of-bool
vector-of-bool approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple. LGTM.

@vector-of-bool vector-of-bool merged commit 36b379c into microsoft:develop Apr 23, 2018
@vector-of-bool vector-of-bool added this to the 0.11.1 milestone Apr 23, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vector-of-bool vector-of-bool vector-of-bool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbosnjak @vector-of-bool @mebbosnjak