Bugfix/remove lowercase in diagnostic path #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbosnjak
force-pushed
the
bugfix/remove_lowercase_in_diagnostic_path
branch
from
7430bc2
to
5faf41c
Compare
|
I think this relates to needing a proper canonicalization of Windows paths. I'm just not sure how to go about doing it. LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes visible behavior
OS: windows
Path in diagnostic output are converted to lowercase. If there is name in path not in lowercase, when clicking on issue in "PROBLEMS" window vscode will open new editor window with same file just lowercase name.