Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for PR-style squash for feature and release branches #30

Open
JustinGrote opened this issue Jul 1, 2018 · 4 comments
Open

Comments

@JustinGrote
Copy link

Hello,

Love the extension but currently having to squash feature branches before merging. A toggle setting in User Settings that would just add -S to the "finish" command would be great.

Proposed setting name: gitflow.squashBranchOnFinish

@sebastianmacias
Copy link

I'm currently needing to squash commits before merging as well. Are there any plans to implement this?

@anhthang
Copy link

@JustinGrote @sebastianmacias do you guys still need this feature? what's your prefer/expectation on the merge action:

  • checkout develop branch, merge the feature branch with --squash (git merge --squash feature/name)
  • rebase the feature branch first with the command like: git rebase -i HEAD~3, then checkout the develop branch and merge with the default option

@JustinGrote
Copy link
Author

JustinGrote commented May 13, 2020

I now use GitDoc + Github Issues and Requests which meets this need for me, and most repositories I work with now have master gated with branch policies so git flow doesn't work as well for me anymore since I can't commit directly to master.

https://marketplace.visualstudio.com/items?itemName=vsls-contrib.gitdoc#collapsing-versions

To implement here, I'd recommend it be a git merge --squash --edit so that it pops up a vscode window that I can then edit the collapsed commit before closing and saving.

@anhthang
Copy link

glad to hear that you can resolve your issues and continue the works. your recommendation is my idea also. I have published a new version here with a setting to squash features during merge.

https://marketplace.visualstudio.com/items?itemName=buianhthang.gitflow

try it and give me comment if you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants