Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Idea]: Add support for installer dependencies #292

Closed
licon4812 opened this issue Mar 20, 2024 · 3 comments
Closed

[Feature/Idea]: Add support for installer dependencies #292

licon4812 opened this issue Mar 20, 2024 · 3 comments
Labels
feat New feature request

Comments

@licon4812
Copy link

What would you like to see changed/added?

Winget now supports the declaration and installation of dependencies in the manifests. Is this something we can look into for this github action?

Example Manifest with Dependencies:

# Created with YamlCreate.ps1 v2.2.12 $debug=NVS1.CRLF.5-1-22621-2506.Win32NT
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json

PackageIdentifier: tbillington.kondo
PackageVersion: "0.8"
InstallerLocale: en-US
InstallerType: zip
Commands:
- kondo
ReleaseDate: 2023-12-19
Installers:
- Architecture: x86
  NestedInstallerType: portable
  NestedInstallerFiles:
  - RelativeFilePath: kondo.exe
    PortableCommandAlias: kondo
  InstallerUrl: https://github.com/tbillington/kondo/releases/download/v0.8/kondo-x86_64-pc-windows-msvc.zip
  InstallerSha256: 36FB33D71CE6896BFBC0A5F26809AD1BE986EFE9C5C887BA9D3955D8CDEE7895
  Dependencies:
    PackageDependencies:
      - PackageIdentifier: Microsoft.VCRedist.2015+.x86
        InstallerType: exe
        InstallerUrl: https://aka.ms/vs/16/release/vc_redist.x86.exe
- Architecture: x64
  NestedInstallerType: portable
  NestedInstallerFiles:
  - RelativeFilePath: kondo.exe
    PortableCommandAlias: kondo
  InstallerUrl: https://github.com/tbillington/kondo/releases/download/v0.8/kondo-x86_64-pc-windows-msvc.zip
  InstallerSha256: 36FB33D71CE6896BFBC0A5F26809AD1BE986EFE9C5C887BA9D3955D8CDEE7895
  Dependencies:
    PackageDependencies:
      - PackageIdentifier: Microsoft.VCRedist.2015+.x64
        InstallerType: exe
        InstallerUrl: https://aka.ms/vs/16/release/vc_redist.x64.exe

ManifestType: installer
ManifestVersion: 1.5.0
@licon4812 licon4812 added the feat New feature request label Mar 20, 2024
@vedantmgoyal9
Copy link
Owner

vedantmgoyal9 commented Jun 27, 2024

Sorry for the late reply. The action uses manifests from the package's previous version to create new manifests. As long as installer dependencies are present in the old version, they will be automatically taken in the new manifests.

@vedantmgoyal9
Copy link
Owner

@allcontributors please add @licon4812 for ideas

Copy link
Contributor

@vedantmgoyal9

I've put up a pull request to add @licon4812! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature request
Projects
None yet
Development

No branches or pull requests

3 participants
@licon4812 @vedantmgoyal9 and others