Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean rendering functions #41

Closed
VedVid opened this issue Nov 14, 2018 · 1 comment
Closed

Clean rendering functions #41

VedVid opened this issue Nov 14, 2018 · 1 comment

Comments

@VedVid
Copy link
Owner

VedVid commented Nov 14, 2018

For example, RenderCreatures does sort all Creatures! It's not effective in terms of performance, not elegant (it's rendering function, it should do display work only), and makes whole rendering codebase a bit inconsistent ("range" vs "iterate downwards").
@VedVid VedVid added enhancement New feature or request low [priority] labels Nov 14, 2018
@VedVid
Copy link
Owner Author

VedVid commented Nov 14, 2018

Reverting 667b9d0 by a6dc4ac closes that issue.

@VedVid VedVid closed this as completed Nov 14, 2018
@VedVid VedVid removed enhancement New feature or request low [priority] labels Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VedVid