[BUG] - expected AsyncNoTlsStream, found AsyncNativeTlsStream

[brunoarueira]

Description

On a pet project I'm working on, I've set to use async-native-tls feature and when I use into_secure with AsyncNativeTlsConnector::from(TlsConnector::new()), similar to the README, I got the error from title of this bug.

Steps to reproduce

Steps to reproduce the bug you encountered:

use std::error::Error;
use suppaftp::{AsyncFtpStream, AsyncNativeTlsConnector};
use suppaftp::async_native_tls::{TlsConnector, TlsStream};

#[tokio::main]
async fn main() -> Result<(), Box<dyn Error>> {
    // Create a connection to an FTP server and authenticate to it.
    let mut ftp_stream = AsyncFtpStream::connect("localhost:21").await.unwrap();

    let mut connector = TlsConnector::new();

    let mut ftp_stream =
        ftp_stream
        .into_secure(AsyncNativeTlsConnector::from(connector), "localhost")
        .await
        .unwrap();

    Ok(())
}

Probably the bug is about this:

suppaftp/suppaftp/src/lib.rs

Line 183 in 5bf40b4

pub type AsyncFtpStream = ImplAsyncFtpStream<AsyncNoTlsStream>;

Missing to generate a type for async-native-tls feature.

Expected behaviour

Using the above code must work as expected and should compile at least.

Environment

• OS: Darwin
• Architecture x86_64
• Rust version: 1.72.0
• library version: 5.2.0
• Protocol used: ftp
• Remote server version and name: vsftpd 3.0

Additional information

None

[brunoarueira]

After digging a little bit, I've found the correct way to do the connection using async-native-tls, we should use the following type:

suppaftp/suppaftp/src/lib.rs

Line 192 in 5bf40b4

pub type AsyncNativeTlsFtpStream = ImplAsyncFtpStream<AsyncNativeTlsStream>;

So, probably I'll send a pr to fix the docs 😄