Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar in docs gets scrambled at a certain window width #3397

Closed
joelostblom opened this issue Apr 9, 2024 · 2 comments · Fixed by #3401
Closed

Navbar in docs gets scrambled at a certain window width #3397

joelostblom opened this issue Apr 9, 2024 · 2 comments · Fixed by #3401

Comments

@joelostblom
Copy link
Contributor

What happened?

This is low prio, but the docs navbar get a bit scrambled in "medium" screen width. It looks fine in wide screen:

image

And narrow:

image

But there is an in-between for a few pixel that looks wonky, particularly for all the icons to the right:

image

What would you like to happen instead?

I think we should snap to narrow earlier to avoid the scrambled appearance.

Which version of Altair are you using?

No response

@binste
Copy link
Contributor

binste commented Apr 12, 2024

I didn't find any theme variable in https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/styling.html which we could use to do this. Maybe we'd need to adjust the lg bootstrap breakpoint? But I didn't manage to do this and not sure what side effects it has...

As an alternative, we could "header_links_before_dropdown" from 6 to 4 in conf.py so that the top bar looks like this:

image

it solves the scrambled icons and makes it in general less crowded which is nice too. What do you think?

@joelostblom
Copy link
Contributor Author

I like it! We could probably set a breakpoint in the CSS for screen sizes as you mentioned, but I prefer your solution with the dropdown to make the bar less crowded on all screen sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants