-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn before navigating away #69
Comments
I prefer showing a warning in all cases in which we actually might lose the work. |
Another option would be to save the undo history in local storage (at least some of it). |
We can give a save button (or Ctrl+S shortcut) so that one can save whenever required and show a warning in cases like closing tab/navigating without saving, same as a normal editor does. It is the more intuitive. |
Well, in manual mode, you could also lose work, right? We could add a warning for that case. |
@domoritz I switched to manual mode and did some changes. I refreshed the page and my changes were still there. Am I misunderstanding something? |
Did you |
@domoritz No, I did not. The changes are preserved I guess. |
Too often, we accidentally navigate back and lose the work. We should either make sure to not immediately save to local storage or show a warning.
The text was updated successfully, but these errors were encountered: