Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn before navigating away #69

Closed
domoritz opened this issue May 16, 2018 · 8 comments
Closed

Warn before navigating away #69

domoritz opened this issue May 16, 2018 · 8 comments

Comments

@domoritz
Copy link
Member

Too often, we accidentally navigate back and lose the work. We should either make sure to not immediately save to local storage or show a warning.

@ydlamba
Copy link
Member

ydlamba commented May 16, 2018

I prefer showing a warning in all cases in which we actually might lose the work.

@domoritz
Copy link
Member Author

domoritz commented May 16, 2018

Another option would be to save the undo history in local storage (at least some of it).

@ydlamba
Copy link
Member

ydlamba commented May 17, 2018

We can give a save button (or Ctrl+S shortcut) so that one can save whenever required and show a warning in cases like closing tab/navigating without saving, same as a normal editor does. It is the more intuitive.

@algomaster99
Copy link
Member

@domoritz We currently lose the work only when we switch editors and that will probably solve after #12 is fixed.

@domoritz
Copy link
Member Author

Well, in manual mode, you could also lose work, right? We could add a warning for that case.

@algomaster99
Copy link
Member

@domoritz I switched to manual mode and did some changes. I refreshed the page and my changes were still there. Am I misunderstanding something?

@domoritz
Copy link
Member Author

Did you run after making changes?

@algomaster99
Copy link
Member

@domoritz No, I did not. The changes are preserved I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants