Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for newer typescript version #572

Open
DeyLak opened this issue Dec 26, 2022 · 0 comments
Open

Support for newer typescript version #572

DeyLak opened this issue Dec 26, 2022 · 0 comments

Comments

@DeyLak
Copy link

DeyLak commented Dec 26, 2022

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch react-vega@7.6.0 for the project I'm working on.

I used it with typescript 4.9.4 and got an error

Here is the diff that solved my problem:

diff --git a/node_modules/react-vega/src/utils/getUniqueFieldNames.ts b/node_modules/react-vega/src/utils/getUniqueFieldNames.ts
index cc9c643..74174a1 100644
--- a/node_modules/react-vega/src/utils/getUniqueFieldNames.ts
+++ b/node_modules/react-vega/src/utils/getUniqueFieldNames.ts
@@ -1,4 +1,4 @@
-export default function getUniqueFieldNames<T>(objects: T[]) {
+export default function getUniqueFieldNames<T extends object>(objects: T[]) {
   const fields = new Set<string>();
   objects.forEach(o => {
     Object.keys(o).forEach(field => {

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant