Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve perf and avoid updating data or view when not necessary #58

Merged
merged 3 commits into from
Sep 20, 2019

Conversation

kristw
Copy link
Member

@kristw kristw commented Sep 18, 2019

  • Update data only when new view is created or data is changed (checked by shallow equality)
  • Create new view only when view parameters are changed (excluding style, className and perform shallow equality check on signalHandlers to avoid developer accidentally passing newly created object every time and got huge perf issue.)

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #58   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           2      2           
  Branches        1      1           
=====================================
  Hits            2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15659a...98c67c8. Read the comment docs.

@kristw kristw merged commit 20d99ca into master Sep 20, 2019
@kristw kristw deleted the kristw--perf branch September 20, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant