Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the data in spec changes, the view does not update. #32

Closed
Sparkier opened this issue May 6, 2021 · 3 comments
Closed

When the data in spec changes, the view does not update. #32

Sparkier opened this issue May 6, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Sparkier
Copy link
Collaborator

Sparkier commented May 6, 2021

If the data that is embedded into spec changes (not any of the keys in data), the view does not update.

@Sparkier Sparkier added the bug Something isn't working label May 6, 2021
@Sparkier Sparkier self-assigned this May 6, 2021
@Sparkier Sparkier closed this as completed May 6, 2021
@domoritz
Copy link
Member

domoritz commented May 6, 2021

What was the resolution here?

@Sparkier
Copy link
Collaborator Author

Sparkier commented May 6, 2021

I had another issue which made me think this was the case, but I think it is not as I thought.
This is the check if those spec fields are equal (including the data):

    fieldNames.some(
      (field) =>
        !(field in newSpec) ||
        !(field in oldSpec) ||
        !equal(
          newSpec[field as keyof typeof newSpec],
          oldSpec[field as keyof typeof oldSpec]
        )
    )

@Sparkier
Copy link
Collaborator Author

Sparkier commented May 6, 2021

I think my problem was specifically related to the way I feed arrow data to svelte-vega.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants