-
Notifications
You must be signed in to change notification settings - Fork 591
/
properties.test.ts
449 lines (397 loc) · 17.6 KB
/
properties.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
import {range} from 'd3-array';
import {AxisOrient, Orient, SignalRef} from 'vega';
import {codegenExpression, parseExpression} from 'vega-expression';
import {stringValue} from 'vega-util';
import {getAxisConfigs} from '../../../src/compile/axis/config';
import * as properties from '../../../src/compile/axis/properties';
import {defaultLabelAlign, defaultLabelBaseline, getLabelAngle} from '../../../src/compile/axis/properties';
import {TimeUnit} from '../../../src/timeunit';
import {normalizeAngle} from '../../../src/util';
import {isSignalRef} from '../../../src/vega.schema';
describe('compile/axis/properties', () => {
function evalValueOrSignal(valueOrSignalRef: string | SignalRef, o: Orient) {
if (isSignalRef(valueOrSignalRef)) {
const ast = parseExpression(valueOrSignalRef.signal);
const {code} = codegenExpression({
globalvar: ((v: string) => (v === 'o' ? stringValue(o) : undefined)) as any
})(ast);
return eval(code);
}
return valueOrSignalRef;
}
describe('defaultGrid()', () => {
it('should return true by default for continuous scale that is not binned', () => {
const grid = properties.defaultGrid('linear', {field: 'a', type: 'quantitative'});
expect(grid).toBe(true);
});
it('should return false by default for binned field', () => {
const grid = properties.defaultGrid('linear', {bin: true, field: 'a', type: 'quantitative'});
expect(grid).toBe(false);
});
it('should return false by default for a discrete scale', () => {
const grid = properties.defaultGrid('point', {field: 'a', type: 'quantitative'});
expect(grid).toBe(false);
});
});
describe('orient()', () => {
it('should return bottom for x by default', () => {
const orient = properties.defaultOrient('x');
expect(orient).toBe('bottom');
});
it('should return left for y by default', () => {
const orient = properties.defaultOrient('y');
expect(orient).toBe('left');
});
});
describe('defaultTickCount()', () => {
it('should return size/10 by default for a binned field', () => {
const tickCount = properties.defaultTickCount({
fieldOrDatumDef: {bin: {maxbins: 10}, field: 'a', type: 'quantitative'},
scaleType: 'linear',
size: {signal: 'a'}
});
expect(tickCount).toEqual({signal: 'ceil(a/10)'});
});
it('should return undefined if values is specified', () => {
const tickCount = properties.defaultTickCount({
fieldOrDatumDef: {bin: {maxbins: 10}, field: 'a', type: 'quantitative'},
scaleType: 'linear',
size: {signal: 'a'},
values: [1, 2, 3]
});
expect(tickCount).toBeUndefined();
});
for (const timeUnit of ['month', 'hours', 'day', 'quarter'] as TimeUnit[]) {
it(`should return undefined by default for a temporal field with timeUnit=${timeUnit}`, () => {
const tickCount = properties.defaultTickCount({
fieldOrDatumDef: {timeUnit, field: 'a', type: 'temporal'},
scaleType: 'linear',
size: {signal: 'a'}
});
expect(tickCount).not.toBeDefined();
});
}
it('should return size/40 by default for linear scale', () => {
const tickCount = properties.defaultTickCount({
fieldOrDatumDef: {field: 'a', type: 'quantitative'},
scaleType: 'linear',
size: {signal: 'a'}
});
expect(tickCount).toEqual({signal: 'ceil(a/40)'});
});
it('should return undefined by default for log scale', () => {
const tickCount = properties.defaultTickCount({
fieldOrDatumDef: {field: 'a', type: 'quantitative'},
scaleType: 'log'
});
expect(tickCount).toBeUndefined();
});
it('should return undefined by default for point scale', () => {
const tickCount = properties.defaultTickCount({
fieldOrDatumDef: {field: 'a', type: 'quantitative'},
scaleType: 'point'
});
expect(tickCount).toBeUndefined();
});
});
describe('values', () => {
it('should return correct timestamp values for DateTimes', () => {
const values = properties.values({values: [{year: 1970}, {year: 1980}]}, {field: 'a', type: 'temporal'});
expect(values).toEqual([
{signal: 'datetime(1970, 0, 1, 0, 0, 0, 0)'},
{signal: 'datetime(1980, 0, 1, 0, 0, 0, 0)'}
]);
});
it('should simply return values for non-DateTime', () => {
const values = properties.values({values: [1, 2, 3, 4]}, {field: 'a', type: 'quantitative'});
expect(values).toEqual([1, 2, 3, 4]);
});
it('returns signal correctly for non-DateTime', () => {
const values = properties.values({values: {signal: 'a'}}, {field: 'a', type: 'quantitative'});
expect(values).toEqual({signal: 'a'});
});
it('should simply drop values when domain is specified', () => {
const values = properties.values(
{},
{
type: 'quantitative',
field: 'US_Gross',
bin: {extent: [0, 1]}
}
);
expect(values).toBeUndefined();
});
});
describe('labelAngle', () => {
const axis = {labelAngle: 600};
const configWithLabelAngle = {axis: {labelAngle: 500}};
it('should return the correct labelAngle from the axis definition', () => {
expect(240).toEqual(getLabelAngle({type: 'quantitative', field: 'US_Gross', axis}, axis, 'y', {}));
});
it('should return the correct labelAngle from the axis config definition', () => {
const axisConfigs = getAxisConfigs('y', 'linear', 'left', configWithLabelAngle);
expect(140).toEqual(
getLabelAngle({type: 'quantitative', field: 'US_Gross'}, {}, 'y', configWithLabelAngle, axisConfigs)
);
});
it('should return the correct default labelAngle when not specified', () => {
expect(270).toEqual(getLabelAngle({field: 'a', type: 'ordinal'}, {}, 'x', {}));
});
it('should return the labelAngle declared in the axis when both the axis and axis config have labelAngle', () => {
expect(240).toEqual(
getLabelAngle({type: 'quantitative', field: 'US_Gross', axis}, axis, 'y', configWithLabelAngle)
);
});
it('should return undefined when there is no default and no specified labelAngle', () => {
expect(undefined).toEqual(getLabelAngle({type: 'quantitative', field: 'US_Gross'}, {}, 'y', {}));
});
});
describe('defaultLabelAlign', () => {
it('correctly aligns the x-labels for all degrees', () => {
expect(defaultLabelAlign(0, 'top', 'x')).toBeNull();
expect(defaultLabelAlign(15, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(30, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(45, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(60, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(75, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(90, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(105, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(120, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(135, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(150, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(165, 'top', 'x')).toBe('right');
expect(defaultLabelAlign(180, 'top', 'x')).toBeNull();
expect(defaultLabelAlign(195, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(210, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(225, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(240, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(255, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(270, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(285, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(300, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(315, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(330, 'bottom', 'x')).toBe('right');
expect(defaultLabelAlign(345, 'bottom', 'x')).toBe('right');
});
it('correctly aligns the y-labels for all degrees', () => {
expect(defaultLabelAlign(0, 'left', 'y')).toBe('right');
expect(defaultLabelAlign(15, 'left', 'y')).toBe('right');
expect(defaultLabelAlign(30, 'left', 'y')).toBe('right');
expect(defaultLabelAlign(45, 'left', 'y')).toBe('right');
expect(defaultLabelAlign(60, 'left', 'y')).toBe('right');
expect(defaultLabelAlign(75, 'left', 'y')).toBe('right');
expect(defaultLabelAlign(90, 'left', 'y')).toBe('center');
expect(defaultLabelAlign(105, 'left', 'y')).toBe('left');
expect(defaultLabelAlign(120, 'left', 'y')).toBe('left');
expect(defaultLabelAlign(135, 'left', 'y')).toBe('left');
expect(defaultLabelAlign(150, 'left', 'y')).toBe('left');
expect(defaultLabelAlign(165, 'left', 'y')).toBe('left');
expect(defaultLabelAlign(180, 'left', 'y')).toBe('left');
expect(defaultLabelAlign(195, 'right', 'y')).toBe('right');
expect(defaultLabelAlign(210, 'right', 'y')).toBe('right');
expect(defaultLabelAlign(225, 'right', 'y')).toBe('right');
expect(defaultLabelAlign(240, 'right', 'y')).toBe('right');
expect(defaultLabelAlign(255, 'right', 'y')).toBe('right');
expect(defaultLabelAlign(270, 'right', 'y')).toBe('center');
expect(defaultLabelAlign(285, 'right', 'y')).toBe('left');
expect(defaultLabelAlign(300, 'right', 'y')).toBe('left');
expect(defaultLabelAlign(315, 'right', 'y')).toBe('left');
expect(defaultLabelAlign(330, 'right', 'y')).toBe('left');
expect(defaultLabelAlign(345, 'right', 'y')).toBe('left');
});
it('should return undefined if angle is undefined', () => {
expect(defaultLabelAlign(undefined, 'left', 'y')).toBeUndefined();
});
it('correctly align y-axis labels for labelAngle and orient signals', () => {
const ast = parseExpression(defaultLabelAlign({signal: 'a'}, {signal: 'o'}, 'y')['signal']);
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
for (o of ['left', 'right'] as AxisOrient[]) {
const {code} = codegenExpression({
globalvar: ((v: string) => (v === 'a' ? a : v === 'o' ? stringValue(o) : undefined)) as any
})(ast);
const result = eval(code);
const expected = defaultLabelAlign(normalizeAngle(a), o, 'y');
expect(result).toEqual(expected);
}
}
});
it('correctly align x-axis labels for labelAngle and orient signals', () => {
return new Promise<void>(done => {
const ast = parseExpression(defaultLabelAlign({signal: 'a'}, {signal: 'o'}, 'x')['signal']);
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
for (o of ['top', 'bottom'] as AxisOrient[]) {
const {code} = codegenExpression({
globalvar: ((v: string) => (v === 'a' ? a : v === 'o' ? stringValue(o) : undefined)) as any
})(ast);
const result = eval(code);
const expected = defaultLabelAlign(normalizeAngle(a), o, 'x');
expect(result).toEqual(expected);
}
}
done();
});
});
it('correctly align y-axis labels for orient signal', () => {
return new Promise<void>(done => {
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
a = normalizeAngle(a);
const align = defaultLabelAlign(a, {signal: 'o'}, 'y');
for (o of ['left', 'right'] as AxisOrient[]) {
const result = evalValueOrSignal(align, o);
const expected = defaultLabelAlign(a, o, 'y');
expect(result).toEqual(expected);
}
}
done();
});
});
it('correctly align x-axis labels for orient signal', () => {
return new Promise<void>(done => {
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
a = normalizeAngle(a);
const align = defaultLabelAlign(a, {signal: 'o'}, 'x');
for (o of ['top', 'bottom'] as AxisOrient[]) {
const result = evalValueOrSignal(align, o);
const expected = defaultLabelAlign(a, o, 'x');
expect(result).toEqual(expected);
}
}
done();
});
});
});
describe('defaultLabelBaseline', () => {
it('is middle for perpendiculars horizontal orients', () => {
expect(defaultLabelBaseline(90, 'top', 'x')).toBe('middle');
expect(defaultLabelBaseline(270, 'bottom', 'x')).toBe('middle');
});
it('is top for bottom orients for 1st and 4th quadrants', () => {
expect(defaultLabelBaseline(45, 'bottom', 'x')).toBe('top');
expect(defaultLabelBaseline(180, 'top', 'x')).toBe('top');
});
it('is bottom for bottom orients for 2nd and 3rd quadrants', () => {
expect(defaultLabelBaseline(100, 'bottom', 'x')).toBe('middle');
expect(defaultLabelBaseline(260, 'bottom', 'x')).toBe('middle');
});
it('is middle for 0 and 180 horizontal orients', () => {
expect(defaultLabelBaseline(0, 'left', 'y')).toBeNull();
expect(defaultLabelBaseline(180, 'right', 'y')).toBeNull();
});
it('is top for bottom orients for 1st and 2nd quadrants', () => {
expect(defaultLabelBaseline(80, 'left', 'y')).toBe('top');
expect(defaultLabelBaseline(100, 'left', 'y')).toBe('top');
});
it('is bottom for bottom orients for 3rd and 4th quadrants', () => {
expect(defaultLabelBaseline(280, 'left', 'y')).toBe('bottom');
expect(defaultLabelBaseline(260, 'left', 'y')).toBe('bottom');
});
it('should return undefined if angle is undefined', () => {
expect(defaultLabelBaseline(undefined, 'left', 'y')).toBeUndefined();
});
it('correctly align y-axis labels for labelAngle and orient signals', () => {
return new Promise<void>(done => {
const ast = parseExpression(defaultLabelBaseline({signal: 'a'}, {signal: 'o'}, 'y')['signal']);
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
for (o of ['left', 'right'] as AxisOrient[]) {
const {code} = codegenExpression({
globalvar: ((v: string) => (v === 'a' ? a : v === 'o' ? stringValue(o) : undefined)) as any
})(ast);
const result = eval(code);
const expected = defaultLabelBaseline(normalizeAngle(a), o, 'y');
expect(result).toEqual(expected);
}
}
done();
});
});
it('correctly align x-axis labels for labelAngle and orient signals', () => {
return new Promise<void>(done => {
const ast = parseExpression(defaultLabelBaseline({signal: 'a'}, {signal: 'o'}, 'x')['signal']);
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
for (o of ['top', 'bottom'] as AxisOrient[]) {
const {code} = codegenExpression({
globalvar: ((v: string) => (v === 'a' ? a : v === 'o' ? stringValue(o) : undefined)) as any
})(ast);
const result = eval(code);
const expected = defaultLabelBaseline(normalizeAngle(a), o, 'x');
expect(result).toEqual(expected);
}
}
done();
});
});
it('correctly align y-axis labels for orient signal', () => {
return new Promise<void>(done => {
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
a = normalizeAngle(a);
const baseline = defaultLabelBaseline(a, {signal: 'o'}, 'y');
for (o of ['left', 'right'] as AxisOrient[]) {
const result = evalValueOrSignal(baseline, o);
const expected = defaultLabelBaseline(a, o, 'y');
expect(result).toEqual(expected);
}
}
done();
});
});
it('correctly align x-axis labels for orient signal', () => {
return new Promise<void>(done => {
let a: number;
let o: AxisOrient;
// test all angles
for (a of range(-360, 375, 15)) {
a = normalizeAngle(a);
const baseline = defaultLabelBaseline(a, {signal: 'o'}, 'x');
for (o of ['top', 'bottom'] as AxisOrient[]) {
const result = evalValueOrSignal(baseline, o);
const expected = defaultLabelBaseline(a, o, 'x');
expect(result).toEqual(expected);
}
}
done();
});
});
});
describe('defaultLabelOverlap', () => {
it('returns true for time unit ordinal without sort', () => {
expect(properties.defaultLabelOverlap('ordinal', 'band', true)).toBe(true);
});
it('returns true for time unit ordinal with sort', () => {
expect(properties.defaultLabelOverlap('ordinal', 'band', true, {field: 'x', op: 'min'})).toBeUndefined();
});
it('returns undefined for ordinal and nominal', () => {
expect(properties.defaultLabelOverlap('ordinal', 'band', false)).toBeUndefined();
expect(properties.defaultLabelOverlap('nominal', 'band', false)).toBeUndefined();
});
it('returns greedy for log and symlog scale', () => {
expect(properties.defaultLabelOverlap('quantitative', 'log', false)).toBe('greedy');
expect(properties.defaultLabelOverlap('quantitative', 'symlog', false)).toBe('greedy');
});
});
describe('defaultZindex', () => {
it('returns 1 for discrete axes of rect marks', () => {
expect(properties.defaultZindex('rect', {field: 'a', type: 'nominal'})).toBe(1);
});
});
});