Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend stroke color does not match mark config #1203

Closed
marcprux opened this issue Mar 1, 2016 · 1 comment
Closed

Legend stroke color does not match mark config #1203

marcprux opened this issue Mar 1, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@marcprux
Copy link
Member

marcprux commented Mar 1, 2016

In this example, the fill color of the legend matches the mark's config, but the stroke color does not.

{
  "data": {"url": "data/cars.json"},
  "mark": "point",
  "config": { "mark": { "fill": "red", "stroke": "green", "color": "blue", "strokeWidth": 5 }},
  "encoding": {
    "x": {"field": "Horsepower", "type": "quantitative", "aggregate": "average"},
    "y": {"field": "Miles_per_Gallon", "type": "quantitative", "aggregate": "average"},
    "size": {"field": "Acceleration", "type": "quantitative"}
  }
}

unknown

@domoritz
Copy link
Member

domoritz commented Mar 1, 2016

Ha, I think this is a case where we use an if then else rather than two ifs.

@kanitw kanitw added this to the 1.0.x Important Patches milestone Mar 1, 2016
@willium willium self-assigned this Mar 1, 2016
@kanitw kanitw closed this as completed Mar 2, 2016
@kanitw kanitw modified the milestones: 2.0.0-pre Important Feature & Patches, 1.x.x Patches Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants