Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document about setting width and height via Vega's View Component API #1497

Open
kanitw opened this issue Aug 8, 2016 · 7 comments
Open

Comments

@kanitw
Copy link
Member

kanitw commented Aug 8, 2016

No description provided.

@kanitw kanitw added this to the 1.x.x Important Patches milestone Aug 8, 2016
@kanitw
Copy link
Member Author

kanitw commented Aug 8, 2016

Or clarify that you can't use it (yet)!

@kanitw kanitw modified the milestones: 2.0.0-pre Important Feature & Patches, 2.0.0-APIs Mar 4, 2017
@kanitw kanitw modified the milestones: 2.0.0-APIs, 2.0.0-β Important Feature & Patches, 2.0.0-rc Moderately Important Patches Apr 9, 2017
@kanitw kanitw modified the milestones: 2.0.0 Docs & Examples, 2.0.0-rc Moderately Important Patches Jun 19, 2017
@kanitw
Copy link
Member Author

kanitw commented Jun 19, 2017

I think this probably won't work with Vega-Lite in general

@kanitw kanitw changed the title Support setting width and height in View Component API Clarify that we do not support setting width and height in View Component API Jul 19, 2017
@kanitw kanitw modified the milestones: 2.0.0 Critical Feature & Patches, 2.0.0 Docs & Examples Jul 19, 2017
@kanitw kanitw changed the title Clarify that we do not support setting width and height in View Component API Document about setting width and height via Vega's View Component API Sep 22, 2017
@kanitw
Copy link
Member Author

kanitw commented Sep 22, 2017

Now that we have autosize, this actually can work for single and layered view.

@domoritz
Copy link
Member

Which is sufficiently documented at https://vega.github.io/vega-lite/docs/size.html.

@kanitw
Copy link
Member Author

kanitw commented Oct 29, 2017

I don't see any word in the page about the API

@kanitw kanitw reopened this Oct 29, 2017
@domoritz
Copy link
Member

Ohh, I get it. This is about using the view API.

We should link to the API. I don't think it makes much sense to copy the docs here because the Vega-Lite docs are about the language, not so much the particular implementation.

@kanitw
Copy link
Member Author

kanitw commented Oct 29, 2017

but it may not always work given how we generate signal for range -- If there is a case where it doesn't work, documenting it in vl docs with limitations specific to VL is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants