Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinTransform does not support rangeFormula #2368

Closed
YuhanLu opened this issue May 15, 2017 · 3 comments
Closed

BinTransform does not support rangeFormula #2368

YuhanLu opened this issue May 15, 2017 · 3 comments

Comments

@YuhanLu
Copy link
Contributor

YuhanLu commented May 15, 2017

In #2360, I didn't add format to support rangeFormula and we might need it in the future.

@kanitw kanitw modified the milestone: 2.x.x Features & Patches May 15, 2017
@YuhanLu
Copy link
Contributor Author

YuhanLu commented May 15, 2017

const guide = (model instanceof UnitModel) ? (model.axis(channel) || model.legend(channel) || {}) : {};
we require model.axis or model.legend as a guide to get the format from them but in makeBinFromTransform() we are not supposed to deal with encoding at all. The solution for this is to let user specify format in BinTransform and that might involve a lot changes. So we just don't support rangeFormula for now.

@kanitw
Copy link
Member

kanitw commented May 15, 2017

The solution for this is to let user specify format in BinTransform and that might involve a lot changes.

That's one solution but not a good one. The better one is to only add bin _range when we use the bin field in a channel that requires range, but that is trickier and doesn't seem like worth doing now.

@kanitw
Copy link
Member

kanitw commented Jan 17, 2018

Close as it's a part of #2912

@kanitw kanitw closed this as completed Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants