Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is encodings in BaseSelectionDef only channel #2483

Closed
kanitw opened this issue Jun 9, 2017 · 2 comments
Closed

Is encodings in BaseSelectionDef only channel #2483

kanitw opened this issue Jun 9, 2017 · 2 comments
Assignees
@arvind
Labels
RFC / Discussion 💬 For discussing proposed changes

Comments

@kanitw
Copy link
Member

kanitw commented Jun 9, 2017

Currently it's

encodings?: string[];

but I doubt if it is only projectable Channels (all channels excluding detail/order).
@kanitw kanitw added the RFC / Discussion 💬 For discussing proposed changes label Jun 9, 2017
@kanitw
Copy link
Member Author

kanitw commented Jun 9, 2017

I track down the reference path and it seems to be the case. Will fix this as a part of #1980

@kanitw kanitw closed this as completed Jun 9, 2017
@arvind
Copy link
Member

arvind commented Jun 9, 2017

I'm not sure I understand the question but yes, we could switch encodings to be Channel[].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arvind arvind

Labels
RFC / Discussion 💬 For discussing proposed changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arvind @kanitw