Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Unit Schema (at least for Composite Mark) #4372

Closed
kanitw opened this issue Dec 15, 2018 · 4 comments
Closed

Separate Unit Schema (at least for Composite Mark) #4372

kanitw opened this issue Dec 15, 2018 · 4 comments

Comments

@kanitw
Copy link
Member

kanitw commented Dec 15, 2018

Currently we have one unified UnitSpec (Single View) schema.

This means that the schema will validate all encoding channels for all mark types.

However, as we're moving toward more encoding channels that are specific to composite marks.

We should at least separate composite mark's unit spec from normal unit spec. So that channels like xError won't get suggested by autocompletion and validated by the schema for marks other than errorbar.

We might even want to split these for all mark types. However, given the performance of the current schema generator, I'm a bit worried that it will be too slow if we do that right now (before we dive into improving the schema generator).

cc: @jakevdp This probably help generate better class for composite marks in python too.
I wonder if you have any preference about this? (I think we definitely should do it for composite marks, but not sure if we should do it for normal marks yet.)

@kanitw kanitw added this to the 3.0 (Must have) milestone Dec 15, 2018
@domoritz
Copy link
Member

In the Vega typings, we have encodings for each mark type. It definitely helps with correctness.

@kanitw
Copy link
Member Author

kanitw commented Dec 15, 2018

Oh sure. As said, the only worried i have is that our schema gen, which we need to run for testing, gonna take forever:)

@kanitw
Copy link
Member Author

kanitw commented Jan 12, 2019

Done in latest master.

@kanitw kanitw closed this as completed Jan 12, 2019
@kanitw
Copy link
Member Author

kanitw commented Jan 12, 2019

Will be done in #4440 **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants