feat: use view descriptions for accessibility #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
approved these changes
May 20, 2020
domoritz
force-pushed
the
dom/descriptions-views
branch
from
76e95f4
to
5b95e30
Compare
domoritz
force-pushed
the
dom/descriptions-views
branch
from
5b95e30
to
79318bf
Compare
domoritz
force-pushed
the
dom/descriptions-views
branch
from
79318bf
to
0454b43
Compare
donghaoren
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6519
Note that we do not support descriptions with signals for top-level descriptions. We also only use descriptions for views that create groups such as concatenated charts (i.e. not layered charts).