fix: don't rotate labels for ordinal timeUnit #6649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/labelangle-ordinal-timeunit
branch
from
d2c9104
to
a589c6a
Compare
kanitw
changed the title
kanitw
changed the title
- labelAngle shouldn't depend on a unit model - getAxisConfig should only depend on styleConfigIndex not the whole config
We can skip some labels anyway
kanitw
force-pushed
the
kw/labelangle-ordinal-timeunit
branch
from
5b81346
to
b18b414
Compare
domoritz
approved these changes
Jun 21, 2020
After thinking more, I think it's a bit surprising if changing sort would change its lableAngle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can skip some labels anyway.
I've also checked all examples diff specific to this PR.
They all look better.
Merge #6648 first