feat: allow shared type, scale, axis, legend in shared encoding #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/shared-type-scale-axis
branch
11 times, most recently
from
6d72dd7
to
644854d
Compare
kanitw
force-pushed
the
kw/shared-type-scale-axis
branch
2 times, most recently
from
925d9be
to
a0a5b92
Compare
kanitw
force-pushed
the
kw/shared-type-scale-axis
branch
from
a0a5b92
to
8bbff8b
Compare
kanitw
commented
Jun 27, 2020
| @@ -140,7 +140,7 @@ | |||
| "fill": {"value": "#ccc"}, | |||
| "ariaRoleDescription": {"value": "bar"}, | |||
| "description": { | |||
| "signal": "\"id: \" + (isValid(datum[\"id\"]) ? datum[\"id\"] : \"\"+datum[\"id\"]) + \"; Temperature (F): \" + (format(datum[\"record.low\"], \"\")) + \"; record.high: \" + (format(datum[\"record.high\"], \"\"))" | |||
| "signal": "\"id: \" + (isValid(datum[\"id\"]) ? datum[\"id\"] : \"\"+datum[\"id\"]) + \"; record.low: \" + (format(datum[\"record.low\"], \"\")) + \"; record.high: \" + (format(datum[\"record.high\"], \"\"))" | |||
| @@ -83,7 +83,7 @@ | |||
| "fill": {"value": "#4c78a8"}, | |||
| "opacity": {"value": 0.3}, | |||
| "description": { | |||
| "signal": "\"x: \" + (format(datum[\"x\"], \"\")) + \"; y: \" + (format(datum[\"ny\"], \"\"))" | |||
| "signal": "\"x: \" + (format(datum[\"x\"], \"\")) + \"; ny: \" + (format(datum[\"ny\"], \"\"))" | |||
| @@ -11,7 +11,7 @@ | |||
| "name": "hover_store", | |||
| "values": [ | |||
| { | |||
| "unit": "layer_0_layer_0", | |||
| "unit": "layer_0", | |||
There was a problem hiding this comment.
This is changing because I change unnecessary nesting in the VL spec.
| @@ -79,7 +79,7 @@ | |||
| ], | |||
| "ariaRoleDescription": {"value": "bar"}, | |||
| "description": { | |||
| "signal": "\"Date in 2009: \" + (timeFormat(datum[\"date\"], '%m/%d')) + \"; open: \" + (format(datum[\"open\"], \"\")) + \"; close: \" + (format(datum[\"close\"], \"\"))" | |||
| "signal": "\"Date in 2009: \" + (timeFormat(datum[\"date\"], '%m/%d')) + \"; Price: \" + (format(datum[\"open\"], \"\")) + \"; close: \" + (format(datum[\"close\"], \"\"))" | |||
domoritz
approved these changes
Jun 27, 2020
examples/compiled/layer_line_errorband_2d_horizontal_borders_strokedash.vg.json
Show resolved
Hide resolved
I think it's the least confusing if we don't do aria for the year labels
kanitw
changed the title
kanitw
added a commit
that referenced
this pull request
Jun 28, 2020
See #6682 (comment) for rationale
DougBurke
added a commit
to DougBurke/hvega
that referenced
this pull request
Nov 3, 2020
Add a test of https://vega.github.io/vega-lite/examples/facet_bullet.html since it shows support for the Vega-Lite 4.14 change to support shared encodings: vega/vega-lite#6682 Fortunately we don't disallow this feature so no change is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6675
I've checked all the SVG/VG diff.