Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errorbar thickness and size #6740

Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix: errorbar thickness and size #6740

merged 1 commit into from
Jul 24, 2020

Conversation

chanwutk
Copy link
Contributor

Fix #6495 from the discussion in #6502

  • Drop size encoding in errorbar
  • mark.size sets mark.ticks.size if mark.ticks.size is not specified
  • mark.thickness sets:
    • mark.ticks.thickness if mark.ticks.thickness is not specified
    • mark.rule.size if mark.rule.size is not specified

@chanwutk chanwutk requested review from kanitw and domoritz July 17, 2020 03:52
@chanwutk chanwutk self-assigned this Jul 17, 2020
@domoritz
Copy link
Member

Do you know why we make ticks blue and with lower opacity? That doesn't seem to make sense as a default.

image

@domoritz domoritz merged commit 7960188 into master Jul 24, 2020
@domoritz domoritz deleted the ck/errorbar-thickness-size branch July 24, 2020 16:41
@chanwutk
Copy link
Contributor Author

chanwutk commented Jul 25, 2020 •
edited

I agree, do we want to change the default to black?

@domoritz
Copy link
Member

Hmm, good question. I think the color of the ticks and the rule should be the same and they should have 100% opacity. Maybe for consistency, the color should be blue (default mark color). @kanitw do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz requested changes

@kanitw kanitw Awaiting requested review from kanitw

Assignees

@chanwutk chanwutk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting size of errorbar removes the ticks
2 participants
@chanwutk @domoritz