Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect boxplot when using temporal field #6755

Merged
merged 1 commit into from
Jul 24, 2020
Merged

fix: incorrect boxplot when using temporal field #6755

merged 1 commit into from
Jul 24, 2020

Conversation

chanwutk
Copy link
Contributor

Fix #4524
Fix #4925

Boxplot did not include bins and timeUnits transform into filteredLayersMixins' transform. So, I included them.

@chanwutk chanwutk requested review from kanitw and domoritz July 21, 2020 06:34
@chanwutk chanwutk self-assigned this Jul 21, 2020
@chanwutk
Copy link
Contributor Author

At line 244, do we need the if statement if (boxPlotType === 'tukey')?
boxPlotType is always either 'tukey' or 'min-max', so in this line it is going to always be 'tukey' because it is under another if (if (boxPlotType !== 'min-max')).

@chanwutk chanwutk force-pushed the ck/fix-boxplot-temporal-field branch 2 times, most recently from 7f16bb8 to 6024ce2 Compare July 21, 2020 06:46
@chanwutk chanwutk changed the title fix-boxplot-temporal-field fix: boxplot-temporal-field Jul 21, 2020
@chanwutk chanwutk changed the title fix: boxplot-temporal-field fix: boxplot temporal field Jul 21, 2020
@chanwutk chanwutk changed the title fix: boxplot temporal field fix: incorrect boxplot when using temporal field Jul 21, 2020
@chanwutk chanwutk force-pushed the ck/fix-boxplot-temporal-field branch from 6024ce2 to 065542e Compare July 21, 2020 06:53
@chanwutk chanwutk marked this pull request as ready for review July 21, 2020 06:54
@domoritz
Copy link
Member

At line 244, do we need the if statement if (boxPlotType === 'tukey')?
boxPlotType is always either 'tukey' or 'min-max', so in this line it is going to always be 'tukey' because it is under another if (if (boxPlotType !== 'min-max')).

Good catch. Let's simplify the code.

We can also simplify if (outlierLayersMixins && filteredWhiskerSpec) since filteredWhiskerSpec is always true.

domoritz
domoritz approved these changes Jul 22, 2020
View reviewed changes
src/compositemark/boxplot.ts Outdated Show resolved Hide resolved
@chanwutk chanwutk force-pushed the ck/fix-boxplot-temporal-field branch from 065542e to 9b5b19a Compare July 24, 2020 03:11
@domoritz domoritz merged commit 4b34ce4 into master Jul 24, 2020
@domoritz domoritz deleted the ck/fix-boxplot-temporal-field branch July 24, 2020 16:12
@domoritz
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

@kanitw kanitw Awaiting requested review from kanitw

Assignees

@chanwutk chanwutk

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chanwutk @domoritz