Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make encoding null override parent encoding #6763

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix: make encoding null override parent encoding #6763

merged 1 commit into from
Jul 30, 2020

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Jul 29, 2020 •
edited

Fix #6762

The encoding: null now override parent encoding like expected:

image

@kanitw kanitw requested a review from haldenl July 29, 2020 23:37
@kanitw kanitw merged commit f6c2fca into master Jul 30, 2020
@kanitw kanitw deleted the kw/encoding-null branch July 30, 2020 03:57
@kanitw kanitw restored the kw/encoding-null branch July 30, 2020 03:57
@kanitw kanitw deleted the kw/encoding-null branch August 1, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haldenl haldenl haldenl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encoding channel null does not properly override parent encoding definition
2 participants
@kanitw @haldenl