Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: change default projection to equalEarth #7052

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Conversation

domoritz
Copy link
Member

fixes #5367

@domoritz domoritz requested review from jheer, willium and a team November 18, 2020 01:56
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix! rather than feat!?

@domoritz
Copy link
Member Author

Why is it a fix? I consider this an enhancement (therefore feat!).

Copy link
Member

@willium willium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would be nice to add an example that lets you try different projections with a drop down (as is available in Vega)

@domoritz
Copy link
Member Author

Something like this:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v4.json",
  "width": 500,
  "height": 300,
  "params": [
    {
      "name": "projection",
      "value": "equalEarth",
      "bind": {
        "input": "select",
        "options": [
          "albers",
          "albersUsa",
          "azimuthalEqualArea",
          "azimuthalEquidistant",
          "conicConformal",
          "conicEqualArea",
          "conicEquidistant",
          "equalEarth",
          "equirectangular",
          "gnomonic",
          "mercator",
          "naturalEarth1",
          "orthographic",
          "stereographic",
          "transverseMercator"
        ]
      }
    }
  ],
  "data": {
    "url": "data/world-110m.json",
    "format": {"type": "topojson", "feature": "countries"}
  },
  "projection": {"type": {"expr": "projection"}},
  "mark": {"type": "geoshape", "fill": "lightgray", "stroke": "gray"}
}

Unfortunately, expr doesn't work here yet.

@domoritz domoritz changed the title feat!: change default projection to equalEarth fix!: change default projection to equalEarth Nov 18, 2020
@domoritz domoritz merged commit 2c81034 into master Nov 18, 2020
@domoritz domoritz deleted the dom/projection branch November 18, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default projection type
3 participants