Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow any value as default value in lookup transforms #7074

Merged
merged 1 commit into from Dec 2, 2020
Merged

fix: allow any value as default value in lookup transforms #7074

merged 1 commit into from Dec 2, 2020

Conversation

domoritz
Copy link
Member

Fixes #7073

@domoritz domoritz requested review from marcprux and a team November 30, 2020 20:14
marcprux
marcprux approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@marcprux marcprux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@domoritz domoritz merged commit 522d327 into master Dec 2, 2020
@domoritz domoritz deleted the dom/lookup-schema branch December 2, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcprux marcprux marcprux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lookup transform should permit custom default values
2 participants
@domoritz @marcprux