feat: support images on maps #7296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
Mar 15, 2021
| [vgSizeChannel]: {value: size} | ||
| }; | ||
| } else { | ||
| return { |
There was a problem hiding this comment.
This case not covered by test.
It's probably useful to update the comment since the old comment above is outdated (now there are two subcases)
// use geopoint output if there are lat2/long2 and there is no point position2 overriding lat2/long2.
There was a problem hiding this comment.
I removed the commend and added a test.
domoritz
force-pushed
the
dom/geo-image-size
branch
from
42c4ae1
to
647b0f5
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6580