Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use ancestor parse when the model defines a new dataset #7498

Merged
merged 1 commit into from Aug 17, 2021
Merged

fix: do not use ancestor parse when the model defines a new dataset #7498

merged 1 commit into from Aug 17, 2021

Conversation

domoritz
Copy link
Member

fixes #6944

@domoritz domoritz requested a review from a team May 27, 2021 16:04
@domoritz domoritz mentioned this pull request May 27, 2021
Closed
@domoritz
Copy link
Member Author

@kanitw @arvind can you approve this pull request?

@kanitw kanitw merged commit fe7412d into master Aug 17, 2021
@kanitw kanitw deleted the dom/fix-data-parsing branch August 17, 2021 01:44
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@domoritz @BradyJ27
fix: do not use ancestor parse when the model defines a new dataset (v…
aef1466 
…ega#7498)

fixes vega#6944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing dates can fail for per-view data
2 participants
@domoritz @kanitw