fix: resolve theta to independent by default for faceted charts #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
changed the title
kanitw
approved these changes
Jul 24, 2021
kanitw
changed the title
kanitw
requested changes
Jul 24, 2021
| @@ -4,7 +4,9 @@ import {Resolve, ResolveMode} from '../resolve'; | |||
| import {isConcatModel, isFacetModel, isLayerModel, Model} from './model'; | |||
|
|
|||
| export function defaultScaleResolve(channel: ScaleChannel, model: Model): ResolveMode { | |||
| if (isLayerModel(model) || isFacetModel(model)) { | |||
| if (isFacetModel(model)) { | |||
| return channel === 'theta' ? 'independent' : 'shared'; | |||
There was a problem hiding this comment.
What about radius? I think radius probably should be independent too.
Similarly, I think theta/concat should not be shared for concat.
There was a problem hiding this comment.
I don't know whether I agree. I think radius is actually more easily comparable across facets so it makes sense to share by default.
I agree that theta and radius should be independent in concat. I'll make that change.
domoritz
force-pushed
the
dom/theta-resolve
branch
from
9ecc99f
to
56d4eca
Compare
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
…#7563) * feat: resolve theta to independent for faceted chars * docs: document resolve for theta in facets * feat: don't share theta and radius in concat add tests * chore: update examples [CI] Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for @leibatt for the issue report.