Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use more sets and reduce usage of contains #7745

Merged
merged 3 commits into from Oct 11, 2021
Merged

perf: use more sets and reduce usage of contains #7745

merged 3 commits into from Oct 11, 2021

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Oct 7, 2021

Merge after #7744

@domoritz domoritz requested a review from a team October 7, 2021 02:33
kanitw
kanitw reviewed Oct 8, 2021
View reviewed changes
src/stack.ts Show resolved Hide resolved
kanitw
kanitw approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, except one weird casting.

(That said, I believe a lot of these changes do not matter for actual perf, it might be a better use to time to find a bug to fix rather than doing more of these conversions.)

@domoritz
Copy link
Member Author

domoritz commented Oct 8, 2021

Agreed. I was just curious and needed a somewhat mindless task for an evening.

@domoritz domoritz merged commit 553a13a into master Oct 11, 2021
@domoritz domoritz deleted the dom/actual-set branch October 11, 2021 13:34
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@domoritz @BradyJ27
perf: use more sets and reduce usage of contains (vega#7745)
6562cbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw kanitw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@domoritz @kanitw