Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use child signal for radius if faceted #9232

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

ChiaLingWeng
Copy link
Contributor

close #8754
I found that the range for radius using width and height without checking if the model is faceted

new SignalRefWrapper(() => {
const w = model.getSignalName('width');
const h = model.getSignalName('height');
return `min(${w},${h})/2`;

@ChiaLingWeng ChiaLingWeng requested a review from a team as a code owner January 24, 2024 09:21
src/compile/scale/range.ts Outdated Show resolved Hide resolved
@domoritz domoritz merged commit e11af45 into vega:main Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facet fails on arc
2 participants