Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrongly duplicated functions in the 5.23.0 compiled bundle #3684

Closed
markov00 opened this issue Mar 8, 2023 · 2 comments
Closed

Wrongly duplicated functions in the 5.23.0 compiled bundle #3684

markov00 opened this issue Mar 8, 2023 · 2 comments
Labels
bug For bugs or other software errors

Comments

@markov00
Copy link

markov00 commented Mar 8, 2023

It looks like the latest released version 5.23.0 contains a series of duplicated functions that wrongly interact with each others.

In particular, in my case, the vega.scheme function, used to set given new color scheme palette into an object called schemes, can't be used anymore correctly because the configureScheme function calls instead the duplicated function scheme$1 that checks for color schemes in the object called schemes$1.

Looking at the compiled version in the docs folder I can see this:

https://github.com/vega/vega/blob/fb1092f6b931d450f9c210b67ae4752bd3dd461b/docs/vega.js#L14487-L14498

https://github.com/vega/vega/blob/fb1092f6b931d450f9c210b67ae4752bd3dd461b/docs/vega.js#L33224-L33235

https://github.com/vega/vega/blob/fb1092f6b931d450f9c210b67ae4752bd3dd461b/docs/vega.js#L21458-L21475C3

There are also other interpolated functions that are clearly wrongly bundled like interpolateColors$1, colors$1, discrete$1, continuous$1

The bundled code in 5.22.1 is ok and doesn't present that defect.
It could be due to the latest changes in the rollup configurations, I can't see much more that could have changed the compiled bundle in the diffs from 5.22.1 to 5.23.0

@markov00
Copy link
Author

markov00 commented Mar 8, 2023

I've generated a build locally from a fresh clone of the repo and I can't replicate that problem. So it could be that the build released was done in an environment with some outdated version of the dependencies.

Update:
@jheer I've checked that the duplicated code is returned up to this commit 1365926. Newer commits produce a clean build without duplicated code.

@jheer
Copy link
Member

jheer commented Mar 8, 2023

Thanks! I'll take a look and cut a new release as needed.

@jheer jheer mentioned this issue Mar 8, 2023
@jheer jheer closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For bugs or other software errors
Projects
None yet
Development

No branches or pull requests

2 participants