Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Updating a referral set to a team with an incorrect key #10960

Closed
gordsport opened this issue Mar 21, 2024 · 0 comments · Fixed by #10961
Closed

[Bug]: Updating a referral set to a team with an incorrect key #10960

gordsport opened this issue Mar 21, 2024 · 0 comments · Fixed by #10961
Assignees

Comments

@gordsport
Copy link
Contributor

Problem encountered

It is possible to have a referral set created with Key-1 and to update it to make it a team using Key-2 - Key-2 then owns the team. This means that anyone joining the original keys referral set may join a team set up by someone else.

Observed behaviour

Command used by Key-2

./vegawallet_75_0 transaction send --wallet test --no-version-check --pubkey 10d9d4dccc3412ec13f9a86f583a648eb970d6e6f854033487873024f49ecede --network fairground '{
  "updateReferralSet": {
    "id": "6c6aa13e5fdc206418059d31a66d9cca70647291645efd95aa719433eee4e61e",
    "isTeam": true,
    "team": {
      "name": "VegaRocks like really",
      "teamUrl": "https://discord.com/channels/vegarocks",
      "avatarUrl": "https://vega-rocks/logo-360x360.jpg",
      "closed": false
    }
  }
}'

Expected behaviour

That only the owner of a referral set can update their referral to become a team

Steps to reproduce

  1. Create a referral set with key-1
  2. Using Key-2 update the referral set to become a team owned by Key-2
  3. Using Key-3 join the referral link from Key-1
  4. Observe that the user joining Key-1s referral actually goes into the Key-2s team

Software version

0.74.10

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants