Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Remove name field from SpotProduct #11151

Closed
cdummett opened this issue Apr 18, 2024 · 0 comments · Fixed by #11155
Closed

[Feature]: Remove name field from SpotProduct #11151

cdummett opened this issue Apr 18, 2024 · 0 comments · Fixed by #11155
Assignees
Labels
feature new feature to be developed spot

Comments

@cdummett
Copy link
Contributor

Feature Overview

In order to reduce the friction of proposing spot markets
We will remove the unnecessary name field from the SpotProduct message.
So that the docs are simplified

https://vegaprotocol.slack.com/archives/CAHA5EX0F/p1713438110844349

Specs

  • Field is not mentioned anywhere in the specs, it was originally called base_quote_pair but this was removed in commit cad1bd5.

Tasks

when we build an instrument for a spot market, we have two name fields.

"instrument": {
    "name": "Bitcoin / Tether USD (Spot)",
    "code": "BTC/USDT-SPOT",
    "spot": {
        "baseAsset": None,
        "quoteAsset": None,
        "name": "BTC/USDT",
    },
}

The name field in the SpotProduct should be removed to simplify the proposal JSON any necessary changes made to the protos and APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature to be developed spot
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants