Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove every references to file path in the JSON-RPC wallet API #6905

Closed
5 tasks
ValentinTrinque opened this issue Nov 22, 2022 · 1 comment · Fixed by #7782
Closed
5 tasks

Remove every references to file path in the JSON-RPC wallet API #6905

ValentinTrinque opened this issue Nov 22, 2022 · 1 comment · Fixed by #7782

Comments

@ValentinTrinque
Copy link
Contributor

ValentinTrinque commented Nov 22, 2022

Some JSON-RPC params and results have field with filePath in it. It should be removed.

  • Create wallet
  • import wallet
  • import network
  • isolate key

If something need to display the path, it should be acquired outside of the API itself, directly from the Store structs

Tasks

  • Remove filePath from methods defined above
  • Edit OpenRPC documentation
  • Remove deprecated use of Version (when replaced by KeyDerivatioVersion)
  • Keep a single field to import a network (URL over file path), and prefix by file:// in the CLI when it's a file
  • Bonus Support path alias (such as ~) in the file path input.
@emilbayes
Copy link
Contributor

Today we discussed whether admin.impot_wallet should only take a url parameter, and then allow for the URL to reference eg. file:// if the "backend" supports it. This is a consideration for eg. web wallet which may support loading configs from remote URLs but perhaps not read the local file system.
In the same method a name parameter exists, but the network config also contains a name. The API needs some clarity about how to reconcile the two or perhaps drop one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants