Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Explorer API: transaction by hash should not be case sensitive #7688

Closed
edd opened this issue Feb 24, 2023 · 0 comments · Fixed by #7779
Closed

Block Explorer API: transaction by hash should not be case sensitive #7688

edd opened this issue Feb 24, 2023 · 0 comments · Fixed by #7779

Comments

@edd
Copy link
Member

edd commented Feb 24, 2023

Problem encountered

The following transaction hashes are equivalent, and yet Block Explorer API will only find one:

https://be.testnet.vega.xyz/rest/transactions/C2EB359C17E5DFC67A39D0868BB6D5CE62FBD1AED3985F7D8867485F79B63EC6

https://be.testnet.vega.xyz/rest/transactions/c2eb359c17e5dfc67a39d0868bb6d5ce62fbd1aed3985f7d8867485f79b63ec6

Observed behaviour

BE api matches case sensitively

Expected behaviour

Hashes are not case sensitive, and thus should match regardless of case

Acceptance criteria

The following hashes should all be equivalent and return the same transaction:
c2eb359c17e5dfc67a39d0868bb6d5ce62fbd1aed3985f7d8867485f79b63ec6
C2EB359C17E5DFC67A39D0868BB6D5CE62FBD1AED3985F7D8867485F79B63EC6
C2EB359C17E5DFC67A39D0868BB6D5Ce62FBD1AED3985F7D8867485F79B63EC6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants