Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the SessionBegan interaction easy to identify #7723

Closed
ValentinTrinque opened this issue Mar 1, 2023 · 1 comment · Fixed by #7730
Closed

Make the SessionBegan interaction easy to identify #7723

ValentinTrinque opened this issue Mar 1, 2023 · 1 comment · Fixed by #7730
Assignees
Labels

Comments

@ValentinTrinque
Copy link
Contributor

When the frontend receives a SesionBegan interaction, it doesn't know what workflow is targeted. This prevents the wallet UIs to adapt their displays, which stifle the user experience opportunities.

So we need to add a workflow field (string) to help the front end identify the session that began:

  • 'WALLET_CONNECTION' in the client.connect_wallet method
  • 'TRANSACTION_REVIEW' in the client.<send|sign|check>_transaction methods
  • 'PERMISSION_REQUEST' in the client.list_keys method
@notbot00
Copy link
Contributor

notbot00 commented Mar 1, 2023

just for the record, i've started coding this on the frontend. ideally i would need this workflow field on every interaction event emitted, so i can keep track of them easily. the traceID itself is not enough anymore for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants