You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a user is banned from submitting requests , the ban time and/or ban duration should be returned in the response headers
Also, its usual practice to send a response code of 429 for rate limiting / too many requests , but the system sends out 503 which is misleading.
Observed Result: These ban duration / ban expiry time details are not being returned in the response headers. The status code returned is 503. TBH , no rate limiting header elements are returned in the response.
Expected Result: Ban duration / ban expiry time details should be returned. The response code should be 429.
Example:
rest Response headers are {'Content-Encoding': 'gzip', 'Content-Type': 'application/json, application/grpc', 'Vary': 'Origin', 'Warning': '199 - "The header \'X-Vega-Connection\' is deprecated and now defaults to \'CONNECTED\'. It will be removed in a future version. See https://github.com/vegaprotocol/vega/issues/7385#issuecomment-1398719810"', 'X-Block-Height': '635', 'X-Block-Timestamp': '1678354306213877000', 'X-Vega-Connection': 'CONNECTED', 'Date': 'Thu, 09 Mar 2023 09:32:00 GMT', 'Content-Length': '111'}
rest Response status code is 503
When a user is banned from submitting requests , the ban time and/or ban duration should be returned in the response headers
Also, its usual practice to send a response code of 429 for rate limiting / too many requests , but the system sends out 503 which is misleading.
Observed Result: These ban duration / ban expiry time details are not being returned in the response headers. The status code returned is 503. TBH , no rate limiting header elements are returned in the response.
Expected Result: Ban duration / ban expiry time details should be returned. The response code should be 429.
Example:
Jenkins Logs:
https://jenkins.ops.vega.xyz/job/common/job/system-tests-wrapper/57642/consoleText
Jenkins Run:
https://jenkins.ops.vega.xyz/job/common/job/system-tests-wrapper/57642/
System Tests Branch -
feat_datanode_rate_limiting_1
System Tests Test -
test_datanode_rate_limiting
The text was updated successfully, but these errors were encountered: