Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datanode rate limiting - ban time and ban duration not returned #7804

Closed
MuthuVega opened this issue Mar 9, 2023 · 0 comments · Fixed by #7806
Closed

Datanode rate limiting - ban time and ban duration not returned #7804

MuthuVega opened this issue Mar 9, 2023 · 0 comments · Fixed by #7806
Assignees

Comments

@MuthuVega
Copy link
Contributor

MuthuVega commented Mar 9, 2023

When a user is banned from submitting requests , the ban time and/or ban duration should be returned in the response headers

Also, its usual practice to send a response code of 429 for rate limiting / too many requests , but the system sends out 503 which is misleading.

Observed Result: These ban duration / ban expiry time details are not being returned in the response headers. The status code returned is 503. TBH , no rate limiting header elements are returned in the response.

Expected Result: Ban duration / ban expiry time details should be returned. The response code should be 429.

Example:

rest Response headers are {'Content-Encoding': 'gzip', 'Content-Type': 'application/json, application/grpc', 'Vary': 'Origin', 'Warning': '199 - "The header \'X-Vega-Connection\' is deprecated and now defaults to \'CONNECTED\'. It will be removed in a future version. See https://github.com/vegaprotocol/vega/issues/7385#issuecomment-1398719810"', 'X-Block-Height': '635', 'X-Block-Timestamp': '1678354306213877000', 'X-Vega-Connection': 'CONNECTED', 'Date': 'Thu, 09 Mar 2023 09:32:00 GMT', 'Content-Length': '111'}

rest Response status code is 503

Jenkins Logs:
https://jenkins.ops.vega.xyz/job/common/job/system-tests-wrapper/57642/consoleText

Jenkins Run:
https://jenkins.ops.vega.xyz/job/common/job/system-tests-wrapper/57642/

System Tests Branch - feat_datanode_rate_limiting_1
System Tests Test - test_datanode_rate_limiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants