Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Avoid potential division by 0 in market activity tracker #8402

Closed
ze97286 opened this issue May 30, 2023 · 0 comments · Fixed by #8403
Closed

[Feature]: Avoid potential division by 0 in market activity tracker #8402

ze97286 opened this issue May 30, 2023 · 0 comments · Fixed by #8403
Assignees
@ze97286
Labels
feature new feature to be developed
Milestone
☄️ Cosmic Elevator

Comments

@ze97286
Copy link
Contributor

ze97286 commented May 30, 2023

Feature Overview

To avoid potential division by 0 when calculating the fees accrued by each party in the market during the epoch, if the total fees is 0 return 0 rather than divide by it.
@ze97286 ze97286 added the feature new feature to be developed label May 30, 2023
@ze97286 ze97286 changed the title [Feature]: Avoid potential division by 0 [Feature]: Avoid potential division by 0 in market activity tracker May 30, 2023
@ze97286 ze97286 self-assigned this May 30, 2023
@ze97286 ze97286 mentioned this issue May 30, 2023
Merged
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ze97286 ze97286

Labels
feature new feature to be developed
Projects
Core Kanban
Archived in project
Milestone
☄️ Cosmic Elevator
Development

Successfully merging a pull request may close this issue.

chore: avoid division by 0 in market activity tracker vegaprotocol/vega
2 participants
@ze97286 @gordsport