Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance transfers fraction of balance at 1.01 not rejected #8572

Closed
vega-paul opened this issue Jun 22, 2023 · 0 comments · Fixed by #8573
Closed

Governance transfers fraction of balance at 1.01 not rejected #8572

vega-paul opened this issue Jun 22, 2023 · 0 comments · Fixed by #8573
Assignees
Labels

Comments

@vega-paul
Copy link
Contributor

vega-paul commented Jun 22, 2023

Submitting a request proposal with 1.01 as a fraction of balance results in a TX result but no invalid params message via the wallet, i.e. no rejection evidence of this invalid request.

{"id":"154-4","block":"86158CA29A191FFCF1FF692E922BDCBBC32D0F85289017626CBE4BE0DAD340A5","type":"BUS_EVENT_TYPE_TRANSACTION_RESULT","transactionResult":{"partyId":"94cbc4e8efa2c697f5ba638b9ffc76131b07117bac359ba58c024a5167481f47","status":true,"hash":"28b5f1c579f04039a74c2d255ff9a8ab3c7cb96781d441505fa6f6fee1b86817","proposal":{"reference":"500945D69B","terms":{"closingTimestamp":"1687470380","enactmentTimestamp":"1687470380","newTransfer":{"changes":{"sourceType":"ACCOUNT_TYPE_GLOBAL_REWARD","transferType":"GOVERNANCE_TRANSFER_TYPE_BEST_EFFORT","amount":"1000000000000000000","asset":"d6ff30e5e0fa36ae5a6f7d5303f496ff7a85a5ca6e8a6e843cdf5febb890c1cf","fractionOfBalance":"1.01","destinationType":"ACCOUNT_TYPE_GENERAL","destination":"14ccbfa6d0e4d286b5729ff09832e48dfd8fa24448a6acd83741df8d4f54cfa0","oneOff":{}}}},"rationale":{"description":"Submit Governance Transfer","title":"Governance Transfer: Best_Effort"}}},"version":1,"chainId":"testnet-001","txHash":"28B5F1C579F04039A74C2D255FF9A8AB3C7CB96781D441505FA6F6FEE1B86817"}

No transfer is produced but no rejection either.

Other rejection strings expected onthis field...

     for err in [
            "proposal_submission.terms.change.new_transfer.changes.fraction_of_balance (must be positive)",
            "proposal_submission.terms.change.new_transfer.changes.fraction_of_balance (is not a valid value)",
        ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants