Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement amends for pegged orders #2534

Closed
peterbarrow opened this issue Nov 4, 2020 · 1 comment
Closed

Implement amends for pegged orders #2534

peterbarrow opened this issue Nov 4, 2020 · 1 comment
Labels
pegged-orders Work around the pegged order system
Milestone
💃 Flamenco Tavern

Comments

@peterbarrow
Copy link
Contributor

Add support for amending pegged orders

  • Add optional pegged order fields to the amend message (gRPC and GraphQL)
  • Validate the new field values are correct
  • Handle the amend in the matching engine
@peterbarrow peterbarrow added the pegged-orders Work around the pegged order system label Nov 4, 2020
@peterbarrow peterbarrow self-assigned this Nov 4, 2020
peterbarrow added a commit that referenced this issue Nov 5, 2020
@peterbarrow
Adding new pegged order amends message fields (#2534)
b755332
peterbarrow added a commit that referenced this issue Nov 6, 2020
@peterbarrow
Adding unit tests for amending pegged orders (#2534)
94cd35d
peterbarrow added a commit that referenced this issue Nov 9, 2020
@peterbarrow
Testing amending parked orders (#2534)
f1df9d6
peterbarrow added a commit that referenced this issue Nov 9, 2020
@peterbarrow
Added more tests for auctions and parking/unparking (#2534)
6a5829e
peterbarrow added a commit that referenced this issue Nov 9, 2020
@peterbarrow
Multiple field amend tests (#2534)
4fa6d49
peterbarrow added a commit that referenced this issue Nov 11, 2020
@peterbarrow
Fixing issues (#2534)
cfe129b
peterbarrow added a commit that referenced this issue Nov 11, 2020
@peterbarrow
GraphQL fixes (#2534)
f2a417c
peterbarrow added a commit that referenced this issue Nov 13, 2020
@peterbarrow
Removed useless metric (#2534)
fd37e6a
peterbarrow added a commit that referenced this issue Nov 13, 2020
@peterbarrow
Used google types for nullable values (#2534)
0010935
peterbarrow added a commit that referenced this issue Nov 17, 2020
@peterbarrow
Code tidyup (#2534)
b3689f7
@peterbarrow peterbarrow assigned ponthief and unassigned peterbarrow Nov 23, 2020
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Adding new pegged order amends message fields (#2534)
f3b9edd
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Adding unit tests for amending pegged orders (#2534)
f2d9b2c
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Testing amending parked orders (#2534)
bd04f91
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Added more tests for auctions and parking/unparking (#2534)
3c8155c
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Multiple field amend tests (#2534)
b89e6c4
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Fixing issues (#2534)
29d4b49
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
GraphQL fixes (#2534)
dd27cab
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Removed useless metric (#2534)
f19f868
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Used google types for nullable values (#2534)
db7962c
witgaw pushed a commit that referenced this issue Nov 25, 2020
@peterbarrow @witgaw
Code tidyup (#2534)
f127bac
@ponthief
Copy link
Contributor

ponthief commented Jan 6, 2021

this has been largely tested within orderAmends suite in system-test.

@ponthief ponthief closed this as completed Jan 6, 2021
@gordsport gordsport added this to the 💃 Flamenco Tavern milestone Jun 8, 2021
@ponthief ponthief removed their assignment Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pegged-orders Work around the pegged order system
Projects
None yet
Milestone
💃 Flamenco Tavern
Development

No branches or pull requests
3 participants
@ponthief @peterbarrow @gordsport