Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpile utilities so that V8 can keep up #181

Closed
ijlyttle opened this issue Nov 14, 2021 · 2 comments
Closed

transpile utilities so that V8 can keep up #181

ijlyttle opened this issue Nov 14, 2021 · 2 comments

Comments

@ijlyttle
Copy link
Contributor

ijlyttle commented Nov 14, 2021

Right now, VL 5.1.0 works, but VL 5.1.1 does not - I think this is because:

As pointed out in the V8 issue, a solution is to transpile what we need for vw_to_svg() and vw_to_vega() into ES5.

@ijlyttle
Copy link
Contributor Author

ijlyttle commented Nov 14, 2021

This might be a bit drastic, but my current thought is to spin a set of functions into its own package, perhaps vegacompile or vegacommand:

  • vw_to_vega()
  • vw_to_svg()
  • vw_write_svg()
  • vw_write_png()
  • vw_to_bitmap()

These all use Vega(-Lite) in a "node" context, rather than a "browser" context.

I think we would still use these functions from {vegawidget}, but have {vegacompile} as a "Suggests".

It might be useful to encapsulate all these headaches in their own package.

@ijlyttle
Copy link
Contributor Author

this is obviated with the release of {V8} 4.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant