New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code to use go/types instead of go/ast #41
Comments
I don't really want to make mockery go 1.5 only. How do we avoid doing that and using go/types? |
@evanphx before adding go/types to the stdlib there was Since it's a command-line tool, would it be enough to cross-compile the tool and publish the binaries for people with Go < 1.5? |
Maybe it's a matter of time to deprecate Go < 1.5 support. |
@ernesto-jimenez 's suggestion to release binaries seems good to me... |
What about now, since go 1.6 is already here could you reconsider dropping support for go < 1.5? :D |
Let's do this! Time to move on now that most everyone is on 1.5. |
It's done! It's in! Thanks so much for the idea and code to get started @ernesto-jimenez! |
On issue #18 I mentioned that Go 1.5's
go/types
package I stated that the change should allow simplifying the codebase.I wanted to see how much work it would mean so I did a quick implementation from scratch using
go/types
.The implementation results in ~24% less and the following bugs are fixed: #18 #19 #40
The text was updated successfully, but these errors were encountered: