Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulkan] GenerateMipmaps only generates mipmaps for the first face of a cubemap #347

Closed
Doom2fan opened this issue Jan 20, 2021 · 3 comments

Comments

@Doom2fan
Copy link
Contributor

GenerateMipmaps seems to be only generating mipmaps for the first face (X+) in Vulkan. All other faces are left empty.

OpenGL generates mipmaps for all faces correctly, and I can't check this with D3D11 on my engine, due to this issue and this other issue in Veldrid.SPIRV. I'll try to make a simple, isolated test sample for this issue ASAP.

@Doom2fan
Copy link
Contributor Author

Doom2fan commented Jan 20, 2021

Here's a hacked-up test made on top of NeoDemo. The skybox will have all zeroes for the mipmaps of faces other than X+, so it'll look like this:
image

D3D11 exhibits a similar issue. (#348)

@Doom2fan
Copy link
Contributor Author

This is caused by GenerateMipmaps forgetting to account for cubemaps' ArrayLayers counting whole cubemaps and not faces. I've made a PR (#349) that fixes this and issue #346.

@Doom2fan
Copy link
Contributor Author

This can be closed now that #349 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants